KLook - quick preview extension for Dolphin

[Frank Reininghaus]

2012/8/29 Sergey Borovkov:
> Here. This time fixed. Should blame my own stupidity (forgot to add 2 files
> before doing git diff). For convenience I united 2 patches in 1.

Thanks. I could build the patched Dolphin and KLook now (after
removing the erroneous ")" from CMakeLists.txt).

I found a couple of problems:

1. When opening KLook by clicking the "preview toggle" or pressing
space, it always crashes with the attached backtrace.

2. When clicking the "preview toggle" of an item, the item is not only
previewed, but also opened.

3. (the most serious one): If the icon size is small, the selection
marker and the "preview toggle" overlap. I have no good idea what to
do about this :-(

Best regards,
Frank
-------------- next part --------------
Application: KLook (klook), signal: Aborted
[KCrash Handler]
#6  0x00007f652ebe0d95 in raise () from /lib64/libc.so.6
#7  0x00007f652ebe22ab in abort () from /lib64/libc.so.6
#8  0x00007f6531aadd63 in qt_message_output (msgType=QtFatalMsg, buf=0x66e7f8 "ASSERT: \"last >= first\" in file kernel/qabstractitemmodel.cpp, line 2467") at global/qglobal.cpp:2260
#9  0x00007f6531aaded6 in qt_message(QtMsgType, const char *, typedef __va_list_tag __va_list_tag *) (msgType=QtFatalMsg, msg=0x7f6531c701e8 "ASSERT: \"%s\" in file %s, line %d", ap=0x7ffff2a7d388) at global/qglobal.cpp:2306
#10 0x00007f6531aae666 in qFatal (msg=0x7f6531c701e8 "ASSERT: \"%s\" in file %s, line %d") at global/qglobal.cpp:2489
#11 0x00007f6531aad928 in qt_assert (assertion=0x7f6531cea4fb "last >= first", file=0x7f6531cea29e "kernel/qabstractitemmodel.cpp", line=2467) at global/qglobal.cpp:2007
#12 0x00007f6531be0b44 in QAbstractItemModel::beginRemoveRows (this=0x893540, parent=..., first=0, last=-1) at kernel/qabstractitemmodel.cpp:2467
#13 0x0000000000428f2b in FileModel::reset (this=0x893540) at /home/kde-devel/kde/src/KDE/klook/src/filemodel.cpp:85
#14 0x0000000000419c11 in DeclarativeViewer::init (this=0x813ab0, urls=..., embedded=false, rc=..., indexToShow=0) at /home/kde-devel/kde/src/KDE/klook/src/declarativeviewer.cpp:138
#15 0x000000000042c12d in KLookApp::newInstance (this=0x7ffff2a7ec10) at /home/kde-devel/kde/src/KDE/klook/src/klookapp.cpp:105
#16 0x00007f6530157d0f in KUniqueApplicationAdaptor::newInstance (this=0x813270, asn_id=..., args=...) at /home/kde-devel/kde/src/KDE/kdelibs/kdeui/kernel/kuniqueapplication.cpp:442
#17 0x00007f6530157f57 in KUniqueApplicationAdaptor::qt_static_metacall (_o=0x813270, _c=QMetaObject::InvokeMetaMethod, _id=0, _a=0x7ffff2a7d900) at /home/kde-devel/kde/build/KDE/kdelibs/kdeui/kuniqueapplication_p.moc:58
#18 0x00007f653015812c in KUniqueApplicationAdaptor::qt_metacall (this=0x813270, _c=QMetaObject::InvokeMetaMethod, _id=0, _a=0x7ffff2a7d900) at /home/kde-devel/kde/build/KDE/kdelibs/kdeui/kuniqueapplication_p.moc:102
#19 0x00007f652f6d9699 in QDBusConnectionPrivate::deliverCall (this=0x66fc30, object=0x813270, msg=..., metaTypes=..., slotIdx=4) at qdbusintegrator.cpp:947
#20 0x00007f652f6d8e3d in QDBusConnectionPrivate::activateCall (this=0x66fc30, object=0x813270, flags=337, msg=...) at qdbusintegrator.cpp:850
#21 0x00007f652f6dd07c in QDBusConnectionPrivate::activateObject (this=0x66fc30, node=..., msg=..., pathStartPos=16) at qdbusintegrator.cpp:1423
#22 0x00007f652f6dda1f in QDBusActivateObjectEvent::placeMetaCall (this=0x8a1bc0) at qdbusintegrator.cpp:1537
#23 0x00007f6531c05afd in QObject::event (this=0x7ffff2a7ec10, e=0x8a1bc0) at kernel/qobject.cpp:1195
#24 0x00007f6531bee40f in QCoreApplication::event (this=0x7ffff2a7ec10, e=0x8a1bc0) at kernel/qcoreapplication.cpp:1727
#25 0x00007f653312aa09 in QApplication::event (this=0x7ffff2a7ec10, e=0x8a1bc0) at kernel/qapplication.cpp:2533
#26 0x00007f6533130518 in QApplicationPrivate::notify_helper (this=0x681c00, receiver=0x7ffff2a7ec10, e=0x8a1bc0) at kernel/qapplication.cpp:4551
#27 0x00007f653312db54 in QApplication::notify (this=0x7ffff2a7ec10, receiver=0x7ffff2a7ec10, e=0x8a1bc0) at kernel/qapplication.cpp:3933
#28 0x00007f653014ce43 in KApplication::notify (this=0x7ffff2a7ec10, receiver=0x7ffff2a7ec10, event=0x8a1bc0) at /home/kde-devel/kde/src/KDE/kdelibs/kdeui/kernel/kapplication.cpp:311
#29 0x00007f6531becb32 in QCoreApplication::notifyInternal (this=0x7ffff2a7ec10, receiver=0x7ffff2a7ec10, event=0x8a1bc0) at kernel/qcoreapplication.cpp:915
#30 0x00007f6536b3c4bb in QCoreApplication::sendEvent (receiver=0x7ffff2a7ec10, event=0x8a1bc0) at ../../include/QtCore/../../src/corelib/kernel/qcoreapplication.h:231
#31 0x00007f6531bedb46 in QCoreApplicationPrivate::sendPostedEvents (receiver=0x0, event_type=0, data=0x64c3d0) at kernel/qcoreapplication.cpp:1539
#32 0x00007f6531bed767 in QCoreApplication::sendPostedEvents (receiver=0x0, event_type=0) at kernel/qcoreapplication.cpp:1432
#33 0x00007f65331fb8f7 in QCoreApplication::sendPostedEvents () at ../../include/QtCore/../../src/corelib/kernel/qcoreapplication.h:236
#34 0x00007f6531c284ec in postEventSourceDispatch (s=0x680020) at kernel/qeventdispatcher_glib.cpp:279
#35 0x00007f652aeec58d in g_main_context_dispatch () from /usr/lib64/libglib-2.0.so.0
#36 0x00007f652aeecd88 in ?? () from /usr/lib64/libglib-2.0.so.0
#37 0x00007f652aeecf59 in g_main_context_iteration () from /usr/lib64/libglib-2.0.so.0
#38 0x00007f6531c28dc3 in QEventDispatcherGlib::processEvents (this=0x64c0b0, flags=...) at kernel/qeventdispatcher_glib.cpp:424
#39 0x00007f6533207ae0 in QGuiEventDispatcherGlib::processEvents (this=0x64c0b0, flags=...) at kernel/qguieventdispatcher_glib.cpp:204
#40 0x00007f6531bea06c in QEventLoop::processEvents (this=0x7ffff2a7eb80, flags=...) at kernel/qeventloop.cpp:149
#41 0x00007f6531bea1f6 in QEventLoop::exec (this=0x7ffff2a7eb80, flags=...) at kernel/qeventloop.cpp:204
#42 0x00007f6531bed1b2 in QCoreApplication::exec () at kernel/qcoreapplication.cpp:1187
#43 0x00007f653312d73e in QApplication::exec () at kernel/qapplication.cpp:3812
#44 0x00000000004194f5 in main (argc=5, argv=0x7ffff2a7f058) at /home/kde-devel/kde/src/KDE/klook/src/main.cpp:72