Review Request: Dolphin: make --select scroll to the item need to be selected

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106209/#review18101
-----------------------------------------------------------

Ship it!


Thanks, looks good! I like patches that simplify code and fix bugs at the same time :-)

>From my point of view, this can be pushed to the 4.9 branch - I don't think that David has objections about the DolphinPart changes.

One bug I noticed when I tried your patch is that selecting items created with the "Create New..." menu does not work reliably in Konqueror, but this is unrelated to your patch, I can even reproduce that in KDE 4.8.

- Frank Reininghaus


On Aug. 26, 2012, 7:37 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106209/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2012, 7:37 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> dolphin and konqueror provides "--select" to select items in arguments, but its not very useful since it doesn't scroll to the corresponding item. This patch is supposed to fix this problem.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinpart.cpp d1626e5 
>   dolphin/src/views/dolphinview.h 1ad4d6c 
>   dolphin/src/views/dolphinview.cpp 233c700 
> 
> Diff: http://git.reviewboard.kde.org/r/106209/diff/
> 
> 
> Testing
> -------
> 
> No problem here and work as expected.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120827/284c3855/attachment.htm>