Review Request: Fix "Incorrect text color for selected hidden items"

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106194/#review18004
-----------------------------------------------------------


There is a problem that may require a new bug report. Currently the Dolphin code assumes the additional roles never get selected in DetailsLayout mode (where only the file name gets highlighted). But when it uses the same color for "hidden" files, this color also applies to the file name.

The result is that the text color is (still) wrong for hidden files in DetailsLayout mode, even with this patch. On a second look, it is possible the reporter was talking about that issue in the first place... Hm.

- Christoph Feck


On Aug. 25, 2012, 10:09 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106194/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2012, 10:09 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> The problem is not the text color, but the wrong background color it "fades" to. Also affects the color of the additional info text lines.
> 
> 
> This addresses bug 305734.
>     http://bugs.kde.org/show_bug.cgi?id=305734
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kstandarditemlistwidget.cpp 7ae7e2e 
> 
> Diff: http://git.reviewboard.kde.org/r/106194/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120825/266039b8/attachment.htm>