Review Request: Bug 305538 - "dolphin --split " does not work

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106171/#review17972
-----------------------------------------------------------

Ship it!


Very nice patch, works like a charm :-)

Please commit to 4.9 and master!

- Frank Reininghaus


On Aug. 24, 2012, 8:01 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106171/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2012, 8:01 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Fix wrong behaviour, when Dolphin is started with --split argument.
>     
> Actual Results:
> dolphin starts without split view
>     
> Expected Results:
> dolphin starts with split view
>     
> New behaviour:
> # no url given - use default url for all two views
> # one url given - use given url for all two views
> # two urls given - open the first url in the left view and the second url in the right view
> 
> 
> This addresses bug 305538.
>     http://bugs.kde.org/show_bug.cgi?id=305538
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinapplication.cpp 0cd51a4 
> 
> Diff: http://git.reviewboard.kde.org/r/106171/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120824/e70c47ee/attachment.htm>