Review Request: Adjust to Ark's new drag'n'drop D-Bus interface

[Raphael Kubo da Costa]

> On Aug. 24, 2012, 12:55 p.m., Frank Reininghaus wrote:
> > Thanks Raphael, looks good!
> > 
> > Are you going to commit to master only or to 4.9 as well? I'll leave it up to you to decide if this change is safe enough, i.e., if you are sure that it does not cause any unexpected problems (the only source of problems that I can think of at the moment would be that the Ark and Dolphin versions installed on some user's machine don't match). Just make sure that you patch Ark and Dolphin at the same time.

I plan on committing it to 4.9 as well, since it's a bug fix. I thought of the version mismatch problem as well, but I don't think there's much we can do besides hoping people have matching versions -- final users shouldn't have any trouble, and people building from git/svn should be able to work around this.


- Raphael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106131/#review17943
-----------------------------------------------------------


On Aug. 23, 2012, 3:53 p.m., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106131/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2012, 3:53 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Ark's drag'n'drop D-Bus interface needs to be changed: so far, the object path was always /DndExtract, but this does not work if Ark is being used as an embedded KPart (in Konqueror or Rekonq, for example), as all tabs will end up calling QDBusConnection::registerObject() with the same path. Only the first call will work, and the result is that dragging and dropping from any tab previewing an archive with Ark will extract from the first archive being previewed.
> 
> To fix that, applications that accept the application/x-kde-dndextract mimetype should now be adjusted to check the application/x-kde-ark-dndextract-service and application/x-kde-ark-dndextract-path ones instead; the former contains the same service information that used to be passed, while the latter tells which object path should be talked to.
> 
> 
> This addresses bug 304860.
>     http://bugs.kde.org/show_bug.cgi?id=304860
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/draganddrophelper.cpp 45e5076 
> 
> Diff: http://git.reviewboard.kde.org/r/106131/diff/
> 
> 
> Testing
> -------
> 
> Dragging and droppping from embedded Ark to Dolphin works as expected.
> 
> 
> Thanks,
> 
> Raphael Kubo da Costa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120824/6480093f/attachment.htm>