Review Request: Adjust to Ark's new drag'n'drop D-Bus interface

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106131/
-----------------------------------------------------------

(Updated Aug. 23, 2012, 3:53 p.m.)


Review request for Dolphin and Frank Reininghaus.


Changes
-------

Use QDBusMessage instead of relying on the interface XML installed by Ark.


Description
-------

Ark's drag'n'drop D-Bus interface needs to be changed: so far, the object path was always /DndExtract, but this does not work if Ark is being used as an embedded KPart (in Konqueror or Rekonq, for example), as all tabs will end up calling QDBusConnection::registerObject() with the same path. Only the first call will work, and the result is that dragging and dropping from any tab previewing an archive with Ark will extract from the first archive being previewed.

To fix that, applications that accept the application/x-kde-dndextract mimetype should now be adjusted to check the application/x-kde-ark-dndextract-service and application/x-kde-ark-dndextract-path ones instead; the former contains the same service information that used to be passed, while the latter tells which object path should be talked to.


This addresses bug 304860.
    http://bugs.kde.org/show_bug.cgi?id=304860


Diffs (updated)
-----

  dolphin/src/views/draganddrophelper.cpp 45e5076 

Diff: http://git.reviewboard.kde.org/r/106131/diff/


Testing
-------

Dragging and droppping from embedded Ark to Dolphin works as expected.


Thanks,

Raphael Kubo da Costa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120823/d3d197d5/attachment.htm>