Review Request: Adjust to Ark's new drag'n'drop D-Bus interface

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106131/#review17900
-----------------------------------------------------------


Thanks Raphael for investigating this bug and for the patch! I have two questions:

1. It looks like the patch would make Ark a hard build time dependency for Dolphin. Am I correct? If yes, is there a good way to fix this?

2. You’ve probably checked this, but just to be sure: is Ark the only possible source for "application/x-kde-dndextract" events? I.e., is it safe to remove the code that handles these?

- Frank Reininghaus


On Aug. 22, 2012, 10:16 p.m., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106131/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2012, 10:16 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Ark's drag'n'drop D-Bus interface needs to be changed: so far, the object path was always /DndExtract, but this does not work if Ark is being used as an embedded KPart (in Konqueror or Rekonq, for example), as all tabs will end up calling QDBusConnection::registerObject() with the same path. Only the first call will work, and the result is that dragging and dropping from any tab previewing an archive with Ark will extract from the first archive being previewed.
> 
> To fix that, applications that accept the application/x-kde-dndextract mimetype should now be adjusted to check the application/x-kde-ark-dndextract-service and application/x-kde-ark-dndextract-path ones instead; the former contains the same service information that used to be passed, while the latter tells which object path should be talked to.
> 
> 
> This addresses bug 304860.
>     http://bugs.kde.org/show_bug.cgi?id=304860
> 
> 
> Diffs
> -----
> 
>   dolphin/src/CMakeLists.txt 8ade487 
>   dolphin/src/views/draganddrophelper.cpp 45e5076 
> 
> Diff: http://git.reviewboard.kde.org/r/106131/diff/
> 
> 
> Testing
> -------
> 
> Dragging and droppping from embedded Ark to Dolphin works as expected.
> 
> 
> Thanks,
> 
> Raphael Kubo da Costa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120823/317102d6/attachment.htm>