Review Request: Bug 196263 - Middle clicking a folder in the locations panel shouldn't activate the new tab

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106069/#review17899
-----------------------------------------------------------

Ship it!


Thanks for the patch! I agree that this makes middle-clicking items in different parts of Dolphin more consistent.

But I think that this should only go into master, not the 4.9 branch, because I prefer not to have behaviour changes like this in bug fix releases.

BTW, I think the slot openNewActivatedTab() in DolphinMainWindow is not needed any more when your patch is applied, right?

- Frank Reininghaus


On Aug. 18, 2012, 9:25 a.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106069/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2012, 9:25 a.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Changed the behaviour when middle clicking folders in places- and folders-panel. Now it opens the folders in a new background tab (General behaviour of Dolphin).
> 
> 
> This addresses bug 196263.
>     http://bugs.kde.org/show_bug.cgi?id=196263
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.cpp f3d23d6 
> 
> Diff: http://git.reviewboard.kde.org/r/106069/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120823/0e207be1/attachment.htm>