Review Request: Fix translations not showin in the Sort by and Additional Information submenus

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106049/#review17507
-----------------------------------------------------------

Ship it!


Thanks Albert! Please go ahead and commit!

I've tried to find out why it broke between 4.8 and 4.9. I think that the bad commit, which removed the i18nc() call, is b2ed362c: 
https://projects.kde.org/projects/kde/kde-baseapps/repository/revisions/b2ed362c9ae7a6e38880b78e42a52c1ebf68c742


- Frank Reininghaus


On Aug. 15, 2012, 11:36 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106049/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2012, 11:36 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> I18N_NOOP2_NOSTRIP as the name says is a no operation so you still need to call i18nc on it
> 
> This used to work, wonder how it broke ;./
> 
> 
> This addresses bug 305228.
>     http://bugs.kde.org/show_bug.cgi?id=305228
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemmodel.cpp f8302cf 
> 
> Diff: http://git.reviewboard.kde.org/r/106049/diff/
> 
> 
> Testing
> -------
> 
> Stuff shows translated now
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120816/e6749111/attachment.htm>