Review Request: show icon size tooltip whe using the slider to adjust icon size
Burkhard Lück
lueck at hube-lueck.de
Mon Aug 13 09:36:41 BST 2012
> On Aug. 12, 2012, 8:48 p.m., Frank Reininghaus wrote:
> > Thanks for the patch, looks good! Please push to master (I think it can't go into 4.9 due to the string freeze).
branches/stable/l10n-kde4/templates/messages/kde-baseapps/dophin.pot
already has this message:
#: statusbar/dolphinstatusbar.cpp:348
#, kde-format
msgctxt "@info:tooltip"
msgid "Size: 1 pixel"
msgid_plural "Size: %1 pixels"
msgstr[0] ""
msgstr[1] ""
So this can go into 4.9 without breaking string freeze
- Burkhard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105990/#review17279
-----------------------------------------------------------
On Aug. 12, 2012, 8:45 a.m., Jekyll Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105990/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2012, 8:45 a.m.)
>
>
> Review request for Dolphin.
>
>
> Description
> -------
>
> That tooltip was lost in commit 35c773768c952e06ae91448665a6a2f8e78b1fb0 . This simple patch is just a copy and paste of the lost code snippet.
>
>
> This addresses bug 292700.
> http://bugs.kde.org/show_bug.cgi?id=292700
>
>
> Diffs
> -----
>
> dolphin/src/settings/viewmodes/viewsettingstab.h 2115da1
> dolphin/src/settings/viewmodes/viewsettingstab.cpp fe043a7
>
> Diff: http://git.reviewboard.kde.org/r/105990/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jekyll Wu
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120813/b30fe589/attachment.htm>
More information about the kfm-devel
mailing list