Review Request: Swap the default shortcuts of "Editabl Localtion" and "Replace Location" actions

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105994/#review17280
-----------------------------------------------------------

Ship it!


I also think that this makes sense, please push to master, but not to 4.9. We don't want to surprise users with behaviour changes in a bug fix release, and making the change only in master gives us some time to see if this shortcut exchange causes any problems.

- Frank Reininghaus


On Aug. 12, 2012, 3:16 p.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105994/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2012, 3:16 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Peter made an excellent summary of the problem in comment #12 of that bug report, so I don't think I need to repeat it here :)
> 
> I agree both "Editable Location" and "Replace Location" actions have their valid user cases, so removing is not good. Swapping the shorcuts to make "Ctrl+L" less surprising seems to be the best solution to me.
> 
> 
> This addresses bug 183821.
>     http://bugs.kde.org/show_bug.cgi?id=183821
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.cpp 1ce5193 
> 
> Diff: http://git.reviewboard.kde.org/r/105994/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120812/996cef46/attachment.htm>