Review Request: KVersionControlPlugin2 interface to implement add some features not available in current interface.

[Peter Penz]

> On Sept. 6, 2011, 4:28 p.m., Sebastian Doerner wrote:
> > Looks good to me. Peter, are you fine with this? The plugin itself will follow next.
> 
> Peter Penz wrote:
>     @Frank: I'm fine with the interface extensions!
>     
>     @Vishesh: Thanks for the patch, it looks fine. Please give me a little bit time to get Dolphin 2 into a state where it shows the version plugin states again, I plan to be finished during the next 10 days with this (~ 16. September). I'd like to take the chance when having a KVersionControlPlugin2 interface to also fix some const-errors of the previous interface. But to test this I need first to get back the version control plugins functionality in Dolphin 2 :-)
> 
> Vishesh Yadav wrote:
>     Ok. So I should put this patch on hold atm, right?

Yes, please. I'll contact you as soon as the patch can be merged.


- Peter


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102541/#review6305
-----------------------------------------------------------


On Sept. 6, 2011, 3:51 p.m., Vishesh Yadav wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102541/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2011, 3:51 p.m.)
> 
> 
> Review request for Dolphin, KDE Base Apps, Peter Penz, and Sebastian Doerner.
> 
> 
> Summary
> -------
> 
> Added KVersionControlPlugin2 interface to let version control plugins be able to show context menu anywhere not just in repositories. Will be useful to implement commands like Clone(in Git, Hg) or Checkout(in SVN). Part of GSoC project "Mercurial Plugin for Dolphin" http://goo.gl/6B2ly
> 
> Not much changes. Just added one function right now. 
> 
> 
> Diffs
> -----
> 
>   lib/konq/CMakeLists.txt 651beff 
>   lib/konq/kversioncontrolplugin.h e6cb2b4 
>   lib/konq/kversioncontrolplugin2.h PRE-CREATION 
>   lib/konq/kversioncontrolplugin2.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102541/diff
> 
> 
> Testing
> -------
> 
> Yes. With my Mercurial plugin and modified Dolphin 1.7 source code, whose patch I havent posted as Dolphin 2 is now coming up.
> 
> 
> Thanks,
> 
> Vishesh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20110906/145227c8/attachment.htm>