Review Request: Use KFileItem::text() where appropriate

Peter Penz peter.penz19 at gmail.com
Fri Nov 25 15:15:41 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103237/#review8467
-----------------------------------------------------------

Ship it!


I agree of course, thanks Sebastian!

- Peter Penz


On Nov. 25, 2011, 3:08 p.m., Sebastian Trueg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103237/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2011, 3:08 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> The title says it all: With KFileItem the user should always see text() instead of name(). The latter is sometimes strange internal stuff as in the case of Nepomuk.
> 
> 
> This addresses bug 287472.
>     http://bugs.kde.org/show_bug.cgi?id=287472
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinviewcontainer.cpp 0c0a387 
>   dolphin/src/kitemviews/kfileitemmodel.cpp 040309d 
>   dolphin/src/views/dolphinview.cpp 91d668e 
> 
> Diff: http://git.reviewboard.kde.org/r/103237/diff/diff
> 
> 
> Testing
> -------
> 
> Manual testing - looks so much better. :)
> 
> 
> Thanks,
> 
> Sebastian Trueg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20111125/009c290d/attachment.htm>


More information about the kfm-devel mailing list