Review Request: Fix stray ampersand in KUrlNavigatorProtocolCombo

Peter Penz peter.penz19 at gmail.com
Fri Nov 4 06:23:26 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103040/#review7928
-----------------------------------------------------------

Ship it!


Thanks Christoph, looks perfect!

- Peter Penz


On Nov. 3, 2011, 7:27 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103040/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2011, 7:27 p.m.)
> 
> 
> Review request for Dolphin and kdelibs.
> 
> 
> Description
> -------
> 
> - fix sizeHint to not include the accelerator
> - respect styles' hint for showing mnemonics
> - respect widgets' enabled() state when drawing the label
> 
> 
> This addresses bug 285163.
>     http://bugs.kde.org/show_bug.cgi?id=285163
> 
> 
> Diffs
> -----
> 
>   kfile/kurlnavigatorprotocolcombo.cpp 1a08a4c 
> 
> Diff: http://git.reviewboard.kde.org/r/103040/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20111104/ffa33fa1/attachment.htm>


More information about the kfm-devel mailing list