[Patch] Prevent FilterSet::addFilter in khtml_filter.cpp from incorrectly parsing rules with options...

Dawit A adawit at kde.org
Sat Jan 29 23:52:29 GMT 2011


Hi,

The attached patch is intended to fix an issue in FilterSet::addFilter
where a wilcard rule with options, e.g. *$image,~image,donottrack, is
parsed as "*". This causes all urls to match this filter and cause
unintended side effects when adblocking is enabled. Note that the
above filter rule was obtained from
easylistdownloadsadblockplusorgeasyprivacyeasylist.txt:

[Adblock Plus 1.1]
! Checksum: BjTRSfga8mRDTYGW3UpIDQ
! EasyPrivacy and EasyList combination subscription
! Last modified: 29 Jan 2011 18:30 UTC
!
! *** easyprivacy.txt ***
! EasyPrivacy - https://easylist.adblockplus.org/
! Expires: 5 days (update frequency)
! Licence: https://easylist-downloads.adblockplus.org/COPYING
!
! Please report any unblocked tracking or problems
! in the forums (http://forums.lanik.us/)
! or via e-mail (easylist.subscription at gmail.com).
!
!-----------------The X-Do-Not-Track header-----------------!
*$image,~image,donottrack
!-----------------General tracking systems-----------------!
! *** easyprivacy/easyprivacy_general.txt ***
-------------- next part --------------
A non-text attachment was scrubbed...
Name: khtml_filter_fix.patch
Type: application/octet-stream
Size: 592 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20110129/c96820d4/attachment.obj>


More information about the kfm-devel mailing list