Review Request: When renaming a file/folder in dolphin, until now it was not possible to confirm the name in case you wanted to leave the name as it is. This is changed

[Peter Penz]

> On Dec. 16, 2011, 12:14 p.m., Nick Shaforostoff wrote:
> > previously this was a good indicator whether we changes smth or not
> 
> Thomas Murach wrote:
>     At least from my point of view it's not "aborting the renaming" but "confirming the name", may it be a new name or the already existing name, but probably that's a matter of personal taste. Anyway, perhaps more people than just me think like this, so it would be more comfortable for them, too.
>     Besides, the old behavior kind of makes you feel that the old file name is "not allowed" , as you can't _confirm_ it. Sure, it's not the worst bug ever, but still...
>     What do you think?

I agree with Thomas here: I don't see a reason to make it harder for users to exit the dialog then it needs to be. 'Esc' would of course work too but (speaking for myself) I also tended to just press 'Return' in the case Thomas' described as I know that I did not change anything and just wanted to "confirm" that the name is already fine.


- Peter


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103414/#review8999
-----------------------------------------------------------


On Dec. 15, 2011, 1:52 p.m., Thomas Murach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103414/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2011, 1:52 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Sometimes you accidentally hit F2 on a wrong file, or you think about it twice and come to the conclusion that the current file name shouldn't change. Then you'd like to hit enter to confirm your choice, but that doesn't work, as the "Ok"-button is disabled until you change the file/folder name. I thought about creating a bug report on this, but then changing it myself was easier than I expected :D
> Btw, of course the current, buggy behavior only appears when not renaming "inline" or "directly" or whatever this is called.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/renamedialog.cpp ee2b15e 
> 
> Diff: http://git.reviewboard.kde.org/r/103414/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas Murach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20111216/2e145120/attachment.htm>