Review Request: When renaming a file/folder in dolphin, until now it was not possible to confirm the name in case you wanted to leave the name as it is. This is changed

[Thomas Murach]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103414/#review8970
-----------------------------------------------------------



dolphin/src/views/renamedialog.cpp
<http://git.reviewboard.kde.org/r/103414/#comment7456>

    These lines were not especially useful anyway... "enable" is true due to the if-statement above, and the check on newName causes the "bug" I wanted to fix...


- Thomas Murach


On Dec. 15, 2011, 1:52 p.m., Thomas Murach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103414/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2011, 1:52 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Sometimes you accidentally hit F2 on a wrong file, or you think about it twice and come to the conclusion that the current file name shouldn't change. Then you'd like to hit enter to confirm your choice, but that doesn't work, as the "Ok"-button is disabled until you change the file/folder name. I thought about creating a bug report on this, but then changing it myself was easier than I expected :D
> Btw, of course the current, buggy behavior only appears when not renaming "inline" or "directly" or whatever this is called.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/renamedialog.cpp ee2b15e 
> 
> Diff: http://git.reviewboard.kde.org/r/103414/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas Murach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20111215/17180534/attachment.htm>