[PATCH] Remove relative offset calculation from RenderImage::nodeAtPoint()

Raphael Kubo da Costa kubito at gmail.com
Tue Mar 16 14:54:49 GMT 2010


On Tuesday 16 March 2010 04:57:23 Germain Garand wrote:
> Le dimanche 14 mars 2010, Raphael Kubo da Costa a écrit :
> > Hey there,
> 
> Hi Raphael,
> 
> > The attached patch removes the call to
> > RenderBox::relativePositionOffset() from RenderImage::nodeAtPoint().
> > This fixes bug 134888 [1].
> > 
> > I'm not 100% sure it doesn't break anything -- at least my usual
> > navigation is still working fine after the change here.
> 
> yes the patch is correct... usage of this method is likely an old leftover
> from times where nodeAtPoint wasn't going through RenderLayer (which are
> already offsets according to 'position: relative')

Alright, thanks. Committed and backported :)




More information about the kfm-devel mailing list