[PATCH] Remove relative offset calculation from RenderImage::nodeAtPoint()

Raphael Kubo da Costa kubito at gmail.com
Sun Mar 14 20:22:22 GMT 2010


Hey there,

The attached patch removes the call to RenderBox::relativePositionOffset() 
from RenderImage::nodeAtPoint(). This fixes bug 134888 [1].

I'm not 100% sure it doesn't break anything -- at least my usual navigation is 
still working fine after the change here.

WebCore does not include this call either, but its commit history doesn't show 
why the call was removed there (the first commit which includes this method in 
RenderImage doesn't have the call).

It'd be nice to hear something from the rendering gurus.

Cheers,
Raphael

[1] https://bugs.kde.org/show_bug.cgi?id=134388
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-bug134388.patch
Type: text/x-patch
Size: 536 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20100314/8459a158/attachment.bin>


More information about the kfm-devel mailing list