libkonq and ABI stability

[David Faure]

On Wednesday 03 February 2010, Aaron J. Seigo wrote:
> hi :)
> 
> what are the ABI commitments for libkonq?
> 
> reason i ask is that KNewMenu and KonqMenuActions aren't used anymore in
> kdebase/apps (i have them removed from the build locally, in fact, after
> checking lxr.kde.org).
> 
> KonqPopupMenuInformation and KonqFileItemCapabilities are similarly unused,
> except by KonqPopupMenuPlugins. in fact, KonqFileItemCapabilities is
> accessible via KonqPopupMenuInformation::capabilties(), and that's exposed
> through KonqPopupMenuPlugin::setup(..). however, according to lxr none of
> the konq plugins in svn.kde.org use
> KonqPopupMenuInformation::capabilties().
> 
> KonqPopupMenuInformation is used by plugins, but it's really now just a
> wrapper around KFileItemListProperties.
> 
> ok, the above is certainly not news to anyone (e.g. dfaure ;) who works on
> libkonq.
> 
> my questions are
> 
> a) can we remove KNewMenu and KonqMenuActions since they are unused? or
> would that violate the ABI guarantees for libkonq?

It would. libkonq is used by file-manager-type apps, like kftp, krusader, etc.

lxr isn't a full view of the world out there.

> b) am i correct in assuming that even bumping the .so version of libkonq
> wouldn't be "good enough" to remove KonqPopupMenuInformation and
> KFileItemListProperties since we have apps in extragear using them? (and
> possibly elsewhere outside of svn.kde.org, of course) and if so, is this a
> "KDE 5" thing or would it realistic to do it earlier (say, in KDE 4.6 or
> some suitably future release)?

Playing with the .so version sounds way to messy to me, but I'm no expert in 
.so numbering.

> [1] they are already labeled as deprecated in the CMakeLists.txt file, but 
> aren't marked as deprecated in the C++ header files.

If nothing in kde is using them, surely they should have a KDE_DEPRECATED 
indeed.

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).