Old Flash? Go upgrade! - New problem with konqueror

[Maksim Orlovich]

> 2010/4/19 Maksim Orlovich <mo85 at cornell.edu>:
>>
>>> With some hacking, I indeed get youtube working.
>>
>> Could you elaborate on what exactly you had to do? I am a bit lost here.
>
> Like mentioned kmplayer I had to make sure the plugin creation goes
> sync, had to bypass a few timeout redirects too.

OK. nspluginviewer's startup is embarrassingly sync, so that's one thing I
probably don't have to worry about.

> Also I need the correct src/movie url, not the docbase. The kpart
> constructor gets the width/height attribute, but not the src
> attribute. Modified the test case as
>
> ...
>    flash.setAttribute("type", "application/x-shockwave-flash");
>    flash.setAttribute("width", "400");
>    flash.setAttribute("height", "300");
>    flash.setAttribute("src", "lux.swf");
>    if ((appendFlash = body.appendChild(flash)) && appendFlash.GetVariable)
> {
>                 version = appendFlash.GetVariable("$version");
>    };
>    body.removeChild(flash);
>    document.write(version);
> ..
> (so width/height/src added)

See, this is what I am confused about. Shouldn't the testcase work
w/o an actual flash file (and also w/o width and height)?

The khtml bug I see it that it views the empty string as relative to
document, and hence completes it to the page URL (might be right for empty
but not null, too). I would think the right thing to do would be to pass
an empty string to openUrl? nspluginviewer has some code for that (it just
does the wrong thing).


>>> KHTML also seems to forget calling closeUrl in the test case
>>> 'body.removeChild(flash);'.
>>
>> closeUrl, or destroying the plugin instance entirely, I wonder?
>
> Either way are fine with me.

Please see the attached. I would appreciate if you told me if it
fixes the youtube-still-playing-sound issue for you.

> At the end of the script, the 'flash' variable goes out of scope, so
> no reference to this DOM object. Might be the cause of destruction
> too, dunno.

Well, going out of scope doesn't mean much since garbage collection might
not happen for a long time.

>> This one should be fixed in more recent versions, if my memory serves me
>> right.
>
> My 4.4 checkout is from yesterday. Can the fix be backported then?

Hmm. It should have been fixed by r1077278, which is way older than that.
Might be a different bug hitting the same assert then.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: object-not-in-document.diff
Type: text/x-patch
Size: 1396 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20100419/9a0f86e4/attachment.bin>