KHTMLView and QToolTip

[Germain Garand]

Le lundi 14 septembre 2009, Martin Koller a écrit :
> On Sunday 13 September 2009 19:43:07 Martin Koller wrote:
> > Hi,
> >
> > in checking https://bugs.kde.org/show_bug.cgi?id=95628
> > I found that KHTMLView/Part does not hide the tooltip when a new HTML
> > page is passed to it.
> > So I propose the following:
> >
> > Index: khtml_part.cpp
> > ===================================================================
> > --- khtml_part.cpp      (Revision 1016745)
> > +++ khtml_part.cpp      (Arbeitskopie)
> > @@ -114,6 +114,7 @@
> >  #include <kurllabel.h>
> >
> >  #include <QtGui/QClipboard>
> > +#include <QtGui/QToolTip>
> >  #include <QtCore/QFile>
> >  #include <QtCore/QMetaEnum>
> >  #include <QtGui/QTextDocument>
> > @@ -1987,6 +1988,9 @@
> >
> >  void KHTMLPart::begin( const KUrl &url, int xOffset, int yOffset )
> >  {
> > +  if ( d->m_view->underMouse() )
> > +    QToolTip::hideText();  // in case a previous tooltip is still shown
> > +
> >    // No need to show this for a new page until an error is triggered
> >    if (!parentPart()) {
> >      removeJSErrorExtension();
>
> Thanks to David Faure I got a go for this patch.
> Still, the following questions remain.

Hi Martin,

for this you could use a similar check in KHTMLView::scrollContentsBy (see 
attached for IMO best spot.)

Thanks,
Germain

-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch
Type: text/x-patch
Size: 553 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20090915/b489ff29/attachment.bin>