Tab moving in Konqueror

[Frank Reininghaus]

On Thursday 24 December 2009 19:43:32 David Faure wrote:
> On Friday 11 December 2009, Frank Reininghaus wrote:
> > Hi David, hi everyone,
> >
> > 2009/12/9 David Faure:
> > > On Wednesday 25 November 2009, Frank Reininghaus wrote:
> > >> it seems that tab moving in Konqueror (and any other app that uses the
> > >> traditional middle-click tab moving) is broken at the moment:
> > >>
> > >> https://bugs.kde.org/show_bug.cgi?id=214646
> > >>
> > >> Regardless of this bug (which should of course be fixed before 4.4.0)
> > >> I'm wondering if it makes sense to use Qt's tab moving with the left
> > >> mouse button in Konqueror instead.
> > >> [...]
> > >> The disadvantage would be that drag&drop of the tab url would not work
> > >> any more, but I would guess that this feature is used a lot less than
> > >> tab moving?
> > >
> > > I guess that makes sense, yes. More "behaviour compatible" with other
> > > browsers, and indeed one can use "duplicate tab" instead of DND (which
> > > also duplicates the current url into another tab, but without
> > > back/forward history).
> >
> > OK, how shall we proceed? I can see 3 options:
> >
> > 1. Make the change now (it's actually a bug fix because tab moving is
> > broken at the moment).
> >
> > 2. Make the change in KDE 4.5.
> >
> > 3. Get further feedback (maybe from usability people) before a decision
> > is made.
> 
> After discussions on IRC with other people, it turns out that I forgot a
>  major use case of DND: DND (of a tab's URL) into other apps. This gets
>  broken if LMB moves tabs, right? Ideally we would start a url dnd when
>  moving the mouse out of the window, but that seems awfully complex at
>  first sight, with most of the logic inside Qt.

Yes, that's true. If I DND URLs to other apps, I always do it by dragging the 
favicon in the location bar, but probably some people drag the tabs instead.

I think that Firefox' tabbar is quite good at providing both DND of tab URLs 
and tab reordering at the same time, but it's probably quite hard to implement 
that on top of Qt's tab moving code :-(

> Also, for old-time konqueror users, it would be good if MMB for moving tabs
> would still work, in addition to LMB.
>
> So, AFAICS, if you make the change now, we have 1 bug fixed (tabs can be
>  moved) and 2 regressions (no more DND, no more MMB moving), right?

There is some code in KTabBar that maps MMB press/release events to LMB events 
if Qt's tab moving is used (just try to move a tab with the MMB in Dolphin to 
see it).

> In that case, would it be feasible to just fix the MMB moving?

Of course this is possible, the easiest way is to revert the bad commit. This 
should be fixed in any case - the point I was trying to make here was that 
users might prefer LMB tab moving to the current LMB behaviour, but I might be 
wrong. In any case, it's probably to late now to try such a behaviour change.

Best regards,
Frank