"Suspicious code" in khtml

Harri Porten porten at froglogic.com
Sun Sep 28 22:51:41 BST 2008


Hi!

I've fixed 3 of the "suspicious code" issues reported by Christoph 
Bartoscheck on kde-core-devel last week. Here are the remaining ones:

Subject: Suspicious code in kdelibs/kdebase revision 864329

- kdelibs/khtml/xml/xml_tokenizer.cpp:505

Line 502 indicates that body can be NULL here. A crash follows.

- kdelibs/khtml/xml/dom_xmlimpl.cpp:483

Line 481 indicates that m_sheet can be NULL here. A crash follows.

- kdelibs/khtml/xml/dom_selection.cpp:827

Line 824 indicates that renderNode can be NULL here. A crash follows.

- kdelibs/khtml/html/html_baseimpl.cpp:735
   kdelibs/khtml/html/html_imageimpl.cpp:160
   kdelibs/khtml/rendering/bidi.cpp:1103,1154

A break might be missing. A fall through comment would be nice.

Harri.




More information about the kfm-devel mailing list