[PATCH] iframes not correctly scrolling when zoomed

[Germain Garand]

Le vendredi 26 septembre 2008, Rafael Fernández López a écrit :
> Hi,
>
Hi Rafael,

> I have written a patch that makes it correctly for iframes scrolling
> when they are zoomed. This will bring wellness also to classes like
> the redirected combobox when it shows its listview for choosing an
> option.
>
> You can try the difference with the URL:
> http://media.ereslibre.es/2008/09/widgets.html
>
> I will keep going on this issue, since as you can see, events (were
> not and) are not being correctly forwarded and mapped to the widgets
> on the iframe.
>
> OK to commit ? (as I say, I will keep working "on the pipe") ;)

the rendering/* changes look nice... (I did not have time to test the patch 
yet though, sorry... if you are confident just go ahead)

otoh, zooming the return value of visibleWidth/Height() looks wrong.. this is 
the viewport size in device pixels, so it must not change when you zoom.

I understand you do that because the parent view needs the iframe zoomed size 
for repaint here:

+        const QRect rect(off.x(), off.y(), visibleWidth(), visibleHeight());
+        w->scroll(dx, dy, rect);

so why not do the scaling directly in there?

speaking of which, this:

+        w->update(rect); // without this update we are getting bad rendering 
when an iframe is zoomed in

won't work, because it will break efficient blitting... if  you can't find why 
it does not work, it should be restricted at least to zoomed views

Greetings,
Germain