[PATCH] Bugs #158932 and #161385 : remounting does not reload the view

[Laurens Vanhove]

Hi all !

I've managed to find a way to fix bugs 158932 and 161385.
To reproduce the bug : mount some volume in dolphin, unmount it (the 
view gets emptied), remount it (the view stays empty).

So the problem was that the view didn't get updated when a volume was 
(re)mounted at or under the current path. My patch adds a class (used by 
DolphinView) that keeps track of solid accessibility changes. When a 
volume accessibility changes to true (=> the volume is mounted) and the 
mountpoint is a substring of the current path a signal is emitted. 
DolphinView gets this signal and reloads.

I suppose the could be a simpler way to get to this result, as the 
sidebartreeview automatically updates, which means that the event 
probably gets eaten somewhere on the way to the view. But to find out 
where that happens would require some serious debugging ... and the fix 
might not be trivial either.
Fortunately because the monitor class is simple and gets created by 
DolphinView the performance impact should be absolutely minimal :-)


I'd be gratefull if anyone would want to review (and if possible commit) 
the patch !
And tell me if there is anything wrong ;-)


Regards,
Laurens
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dolphin-remount-fix.patch
Type: text/x-patch
Size: 9322 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20080911/2f497fe9/attachment.bin>