khtmlview.cpp - correctly places ifdefs ?

Rafael Fernández López ereslibre at kde.org
Thu Jun 26 19:32:41 BST 2008


Hi,

I attach a patch because reading some code to fix couple bugs I hit  
the next code:

     if ( linkCursor!=LINK_NORMAL && isVisible() && hasFocus() ) {
#ifdef Q_WS_X11
	code

#if 0
	code
#endif

         if( !d->cursor_icon_widget ) {
#ifdef Q_WS_X11
	code
#else
	code
#endif
         }

	code
#ifdef Q_WS_X11
	code
#elif defined(Q_WS_WIN)
	code
#else
         //TODO?
#endif
	code
#endif
     }

And since I saw #ifdef foo inside #ifdef foo I thought the outmost  
#endif was misplaced. Here is a patch... I just don't know the logic,  
just that I thought having if(foo) insnide if(foo) isn't very common  
or useful, so probably that #endif was meant to be before.


Regards,
Rafael Fernandez Lopez.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdelibs-khtmlview.diff
Type: text/x-patch
Size: 729 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20080626/99c1a13b/attachment.bin>


More information about the kfm-devel mailing list