KDE/kdebase/apps/konqueror/src
Eduardo Robles Elvira
edulix at gmail.com
Sun Jun 1 00:34:12 BST 2008
SVN commit 815027 by edulix:
Fixing *huge* memory leak in konqueror: in KonqView::~KonqView() we were just not deleting the HistoryEntries. No kidding. Each view can contain *a lot* of HistoryEntries, and each entry contains lots of data: url, locationBarURL, title, buffer, postData, etc. All that was being leaked when deleting konqviews (i.e. closing a tab).
Thanks pinotree for helping out with valgrind and giving me the valgrind output, you rock!
CCMAIL:kfm-devel at kde.org
CCMAIL:faure at kde.org
M +3 -0 konqview.cpp
--- trunk/KDE/kdebase/apps/konqueror/src/konqview.cpp #815026:815027
@@ -131,6 +131,9 @@
delete m_pPart;
}
+
+ qDeleteAll( m_lstHistory );
+ m_lstHistory.clear();
setRun( 0L );
//kDebug(1202) << this << "done";
More information about the kfm-devel
mailing list