[PATCH] Get rid of dialogs when visiting netvibes.com

David Faure faure at kde.org
Wed Jan 16 21:54:57 GMT 2008


On Monday 14 January 2008, Aurélien Gâteau wrote:
> Germain Garand wrote:
> 
> > Le Jeudi 10 Janvier 2008 10:11, Aurélien Gâteau a écrit :
> >> Germain Garand wrote:
> >> > so it would be hard to argue against extending that check to
> >> > ChildFrame::IFrame for consistency.
> >>
> >> Thanks a lot! Attached simple patch do what you suggest. I believe it's
> >> the best way to fix this.
> >>
> > 
> > the patch is not enough I think because we currently do not save the frame
> > type in the page cache. So e.g. using back/forward, you'd get the dialog
> > again.
> 
> You are right, here is a new version.

Ouch, so many separate lists used in parallel (frameServiceNames, frameURLs, frameStateBuffers, frameTypes).
This would be much cleaner with a list-of-structs.... (I know, you didn't start the trend :)

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kfm-devel mailing list