[PATCH] Get rid of dialogs when visiting netvibes.com

Germain Garand germain at ebooksfrance.org
Sat Jan 12 10:29:07 GMT 2008


Le Jeudi 10 Janvier 2008 10:11, Aurélien Gâteau a écrit :
> Germain Garand wrote:
> > so it would be hard to argue against extending that check to
> > ChildFrame::IFrame for consistency.
>
> Thanks a lot! Attached simple patch do what you suggest. I believe it's the
> best way to fix this.
>

the patch is not enough I think because we currently do not save the frame 
type in the page cache. So e.g. using back/forward, you'd get the dialog 
again.

You'd need to save the frame type in KHTMLPart::restoreState/saveState,
right next to where we save/restore the other frame properties
(look for frameServiceTypes for instance)

> Now if only I could get rid of the 6 download progress dialogs which come
> and go, it would be even nicer. But I am not sure it's possible.

I have no idea about that..

Greetings,
Germain




More information about the kfm-devel mailing list