[PATCH] Get rid of dialogs when visiting netvibes.com

Germain Garand germain at ebooksfrance.org
Thu Jan 10 03:25:42 GMT 2008


Le Mercredi 09 Janvier 2008 21:10, Germain Garand a écrit :
> > Yes, I think it is the correct way to fix this bug. Anyone can provide
> > some pointers as to whether it's possible to identify if we are trying to
> > embed a document from an iframe?
>
> If you have a KHTMLPart pointer, then you can check if part->parentPart()
> is non-null. That also covers non-inline frames, but I think that's what
> you want anyway (all elements of a frameset should be embedded, shouldn't
> they?)

sorry for that nonsense... I should have read the thread to really understand 
the question ;/

I think what you are looking for is
KHTMLPart::processObjectRequest( khtml::ChildFrame *child, const KUrl &_url, 
const QString &mimetype )

I see there already is an unconditional exception for OBJECT:

    // Before attempting to load a part, check if the user wants that.
    // Many don't like getting ZIP files embedded.
    // However we don't want to ask for flash and other plugin things..
    if ( child->m_type != khtml::ChildFrame::Object )

so it would be hard to argue against extending that check to 
ChildFrame::IFrame for consistency.

Greetings,
Germain




More information about the kfm-devel mailing list