[PATCH] Get rid of dialogs when visiting netvibes.com

[Aurélien Gâteau]

Aurélien Gâteau wrote:

> David Faure wrote:
> 
>> On Sunday 06 January 2008, Aurélien Gâteau wrote:
>>> More on netvibes:
>>> 
>>> It seems netvibes.com source is full of code like this:
>>> 
>>> <iframe src="/empty.txt"></iframe>
>>> 
>>> Each iframe causes Konqueror to show a "save, open or cancel" dialog.
>>> 
>>> I fixed this by adding text/plain to the list of mime-type special
>>> cases. Main patch is kdelibs_netvibes_nodialog.diff. The other one is to
>>> keep filetypedetails.cpp synced, as requested in kparts/browserrun.cpp.
>>> 
>>> Is it the correct way to fix this?
>> No, this patch would kill any configurability about whether to view text
>> files inline in konqueror or to open a separate application. I object to
>> this patch; a kio_http-specific fix sounds like a much better idea
>> indeed.
> 
> I see your point. I will have a look at kio_http and hopefully come up
> with a better patch.

Here it is. What do you think about it?

Aurélien
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdelibs_netvibes_nodialog2.diff
Type: text/x-diff
Size: 924 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20080107/de761577/attachment.diff>