[PATCH] Get rid of dialogs when visiting netvibes.com

David Faure faure at kde.org
Sun Jan 6 23:06:09 GMT 2008


On Sunday 06 January 2008, Aurélien Gâteau wrote:
> More on netvibes:
> 
> It seems netvibes.com source is full of code like this:
> 
> <iframe src="/empty.txt"></iframe>
> 
> Each iframe causes Konqueror to show a "save, open or cancel" dialog.
> 
> I fixed this by adding text/plain to the list of mime-type special cases.
> Main patch is kdelibs_netvibes_nodialog.diff. The other one is to keep
> filetypedetails.cpp synced, as requested in kparts/browserrun.cpp.
> 
> Is it the correct way to fix this?
No, this patch would kill any configurability about whether to view text files
inline in konqueror or to open a separate application. I object to this patch;
a kio_http-specific fix sounds like a much better idea indeed.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kfm-devel mailing list