[PATCH] Fix crash when visiting netvibes.com

[Aurélien Gâteau]

David Faure wrote:

> On Thursday 03 January 2008, Aurélien Gâteau wrote:
>> Hello,
>> 
>> Visiting http://netvibes.com causes Konqueror to crash.
>> 
>> This is an heavy Ajax powered site. On startup with Konqueror there are
>> six dialogs which prompt the user what to do with empty.txt. When you
>> close them, Konqueror crashes, because the KRun instance showing the
>> dialog has already been deleted by its autodelete system.
>> 
>> Attached patch fixes this by disabling autodelete while the dialog is
>> running.
>> 
>> Is it ok to commit?
> 
> I don't really understand why this patch is necessary in kde4 if it wasn't
> necessary in kde3 -- but I know that answering this question requires
> debugging kde3 again :)

In kde3, the "save or open dialog" does not appear (which is the expected
behavior of the page, but that's another bug I intend to fix).
Assuming kde3 code is similar to kde4, if there is no dialog, then there is
no event loop gets started from KHTMLPart::processObjectRequest() and the
KRun instance does not get deleted in the middle of
KHTMLRun::foundMimeType(). This is probably why kde3 does not need this
fix.

Aurélien