[PATCH] Konqueror Home URL

[Robert Knight]

Hi,

> I was able to implement it just like described in the idea and committed it
> already.

I really don't think that was a good idea.  This is a non-trivial
change which shouldn't go in hours before release tagging.

> The URL requester referres to the current profile, if a
> KonqMainWindow is found higher in the widget hierarchy and it's profile can
> be found

That is a hack to put it mildly.  I'm sure David Faure could have
suggested a better implementation.

Regards,
Robert.

On 03/01/2008, Bernhard Beschow <bbeschow at cs.tu-berlin.de> wrote:
> Hi,
>
> thanks to all commenters for your suggestions! With your help I've been able
> to think about the patch again and I guess the solution looks very good now.
>
> Am Montag 31 Dezember 2007 schrieb Aurélien Gâteau:
> > Robert Knight wrote:
> > > Hi,
> > >
> > > I have to say, I find the dialog somewhat confusing from the
> > > screenshots.  Adding the label and combobox to the right leaves very
> > > little space for the URL entry.  If I were a newcomer to Konqueror I
> > > would be clueless about what the "Profile name" box is for.
> >
> > Same thing here.
>
> I agree.
>
> > > I cannot think of a really good solution to the problem, but some ideas:
> > >
> > > - Only display the home URL for the active profile when opening the
> > > dialog.  Opening the dialog when browsing the web would show the home
> > > web page there.  Opening the dialog when using the file manager would
> > > show the file manager home there.
> > >
> > > - Have two separate boxes for the file management and web browsing
> > > profiles, and another button which opens a dialog which allows the
> > > home URL to be set for any additional profiles.
> >
> > I like your first idea, simple for the ordinary user and still provides the
> > advanced user what he needs. I don't think you want to change the home url
> > of all your profiles very often, so having to switch to a profile to change
> > its url sound ok.
>
> I prefer this idea, too. And I've been thinking of it before but it seemed
> rather impossible to do. The reason is that the configuration dialog and
> konqueror don't actually know about each other. In fact, one could actually
> exist without the other. Now that has changed with the patch.
>
> I was able to implement it just like described in the idea and committed it
> already. The patch doesn't change the GUI, hence there is no need for a
> combobox any more. The URL requester referres to the current profile, if a
> KonqMainWindow is found higher in the widget hierarchy and it's profile can
> be found. Otherwise, the URL requester shows the old behaviour and referres
> to konquerorrc. This means that the home button points to a different home
> url depending on the profile.
>
> For the future, I could think of features here like the ones in firefox: There
> should be some convenience buttons like "use current web page" or "empty web
> page". Unfortunately, this would break string freeze ATM. But the time will
> come when new strings can be added!
>
> Best whishes,
> Bernhard
>