[PATCH] KHTML Remove unnecessary repaints

Roman Jarosz R.Jarosz at sh.cvut.cz
Wed Feb 27 18:44:07 GMT 2008


This is updated patch which also sets correct scrollbars ranges when hidden KHtmlView is resized.

The scrollbar update is necessary because otherwise we can't move contents to new area. (regression from KDE3)

Can I commit?

Roman

On Sun, 10 Feb 2008 20:52:53 +0100, Roman Jarosz <R.Jarosz at sh.cvut.cz> wrote:

>
> Hi,
>
> This patch remove unnecessary repaints in KHtmlView when static widget is used.
>
> The repaints are caused by move call in QScrollAreaPrivate::updateWidgetPosition. This patch
> suppresses calls to that function. It also adds function for scrollbar update because
> updateWidgetPosition is called from QScrollAreaPrivate::updateScrollBars.
>
> This is hacky but right now we change the position back to 0,0 every time the updateWidgetPosition
> is called so why not suppress the call. This will also remove flickering that can be seen in Kopete,
> because the contents is first painted at wrong position (this is result of the move call) and then
> at good one.
>
> Can I commit?
>
> Roman Jarosz
>
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: khtmlremoverepaints2.diff
Type: application/octet-stream
Size: 3027 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20080227/cf2afc40/attachment.obj>


More information about the kfm-devel mailing list