Making path completion case insensitive

[Peter Penz]

Hi,

On Sunday, 7. December 2008 20:25:37 Diaa Sami wrote:
> You can find the patch inline below, it makes path completion case
> insensitive for konqueror and the directiory and file selection common
> dialogs.

From my point of view the patches are OK and should be committed. However the 
decision for this is up to the maintainers. I've set David Faure (= maintainer 
of Konqueror) and Rafael Fernández López (= maintainer of kfiledialog) to CC.

If there are no objections until this weekend, I'd say please go ahead and 
commit them :-)

Best regards,
Peter

>
> -- patch start
> Index: kdebase/apps/konqueror/src/konqmainwindow.cpp
> ===================================================================
> --- kdebase/apps/konqueror/src/konqmainwindow.cpp	(revision 863411)
> +++ kdebase/apps/konqueror/src/konqmainwindow.cpp	(working copy)
> @@ -2975,6 +2975,7 @@ void KonqMainWindow::initCombo()
>
>    m_pURLCompletion = new KUrlCompletion();
>    m_pURLCompletion->setCompletionMode( s_pCompletion->completionMode() );
> +  m_pURLCompletion->setIgnoreCase(true);
>
>    // This only turns completion off. ~ is still there in the result
>    // We do want completion of user names, right?
> Index: kdelibs/kfile/kdirselectdialog.cpp
> ===================================================================
> --- kdelibs/kfile/kdirselectdialog.cpp	(revision 863411)
> +++ kdelibs/kfile/kdirselectdialog.cpp	(working copy)
> @@ -255,6 +255,7 @@ KDirSelectDialog::KDirSelectDialog(const KUrl &sta
>      d->m_urlCombo->setPixmapProvider( new KUrlPixmapProvider() );
>      KUrlCompletion *comp = new KUrlCompletion();
>      comp->setMode( KUrlCompletion::DirCompletion );
> +    comp->setIgnoreCase(true);
>      d->m_urlCombo->setCompletionObject( comp, true );
>      d->m_urlCombo->setAutoDeleteCompletionObject( true );
>      d->m_urlCombo->setDuplicatesEnabled( false );
> Index: kdelibs/kio/kfile/kfiledialog.cpp
> ===================================================================
> --- kdelibs/kio/kfile/kfiledialog.cpp	(revision 863411)
> +++ kdelibs/kio/kfile/kfiledialog.cpp	(working copy)
> @@ -39,6 +39,8 @@
>  #include <kpluginfactory.h>
>  #include <kdebug.h>
>  #include <kwindowsystem.h>
> +#include <kcompletion.h>
> +#include <kurlcombobox.h>
>  #include "kabstractfilewidget.h"
>  #include "kabstractfilemodule.h"
>  #include "krecentdirs.h"
> @@ -254,6 +256,11 @@ KFileDialog::KFileDialog( const KUrl& startDir, co
>
>      if (customWidget)
>       d->w->setCustomWidget(customWidget);
> +
> +    if (!d->native) {
> +        KCompletion *const comp =
> d->w->locationEdit()->completionObject(); +       
> comp->setIgnoreCase(true);
> +    }
>  }
>
>
>
> -- patch end
>
> Thanks