[Semi-patch] Dolphin statusbar in Konqueror

[Simon St James]

Hi Peter,

On Tuesday 26 August 2008 20:51:38 Peter Penz wrote:
> Hi Simon,
>
> Am Tuesday, 26. August 2008 21:18:11 schrieb Simon St James:
> > Hi all,
> >
> > One of these days I'm going to submit a patch that just works, with no
> > known side-effects or drawbacks.
> >
> > Today is not that day :)
> >
> > Please find attached what I hope will be the beginning of a fix for:
> >
> > https://bugs.kde.org/show_bug.cgi?id=155636
>
> Thanks for your work, but please contact David Faure or me _before_
> investigating so much work into a (quite large) patch, otherwise I fear it
> gets very frustrating for you if David or I don't agree with the approach
> in general.
>
> I think this patch goes into the wrong direction: Dolphin and Konqueror
> have different philosophies of the status bar and I see no sense putting
> the status bar logic from Dolphin into the Dolphin Part. E. g. a lot of
> Dolphins statusbar logic is related to showing error messages and
> information messages into the status bar. Konqueror does not do this... I
> also have plans for refactoring some parts of the statusbar in Dolphin to
> be able offering an optional zooming slider.
>
> I have not checked how Konqueror handles the status bar information, but if
> there are signals or whatever missing from the Dolphin part so that
> Konqueror can show the status, then for sure we should add those signals
> into the Dolphin part. But there is no need for exporting the whole
> statusbar including space information to Konqueror.
>
> It is important for me to keep the code in Dolphin straight forward.
> Introducing a DolphinStatusBarController just for updating the statusbar
> information is "too much" from my point of view...
>
> The Dolphin KPart should only export the views (icon view, details view,
> column view). The URL navigator, the filterbar, the context menu, the
> panels, split of views ...  - all the other things are handled by Konqueror
> and Dolphin separately For sure this does not mean that Dolphin and
> Konqueror don't use similar libs for implementing similar functionality (in
> fact: they share a lot of similar libraries already), but the sharing for
> such things is not done with the KPart.
>
> https://bugs.kde.org/show_bug.cgi?id=155636 only wants that the directory
> info and hover info is shown. I think it should be possible solving this in
> a more straight forward manner :-)
>
> So honestly speaking I object against the attached approach and really hope
> that this does not frustrate you. Please let me know if I can support you
> for https://bugs.kde.org/show_bug.cgi?id=155636 and please just contact me
> directly before investigating so much time again.

Ok, that's no problem (and don't worry about any frustration/ investment of 
time: the patch probably looks like more work than it actually was -  it's 
mostly cut'n'paste ;)).  I'll work on a simplified means of fixing the bug in 
a couple of days time - would showing the directory info all the time, except 
when an item is being hovered do the trick? Progress info also seems to 
come "for free" with KParts, so that should be easily added, too.

Can you think of a neat way of avoiding copy'n'pasting the logic from 
selectionStatusBarText(...), or is that acceptable for the time being?

Best Wishes,
Simon