[Semi-patch] Dolphin statusbar in Konqueror

[Simon St James]

Hi all,

One of these days I'm going to submit a patch that just works, with no known side-effects or drawbacks.

Today is not that day :)

Please find attached what I hope will be the beginning of a fix for:

https://bugs.kde.org/show_bug.cgi?id=155636

The bulk of the patch is factoring the status bar logic out of DolphinViewContainer and into a class called, for the time being, StatusBarHandler (something like DolphinStatusBarController might be better, if rather verbose).  I'm going with this approach as I'm guessing exporting DolphinViewContainer in the Part might be rather awkward, but do correct me if I'm wrong :)

The actual bit that pokes the status bar into Konqueror is in DolphinPart and is currently #if 0'd out, for two reasons:

1) Cosmetic - the capacity bar is a little taller than the standard status bar area:

http://etotheipiplusone.com/konq-statusbar.png

2) Functional, and a blocker - Konqueror relies on its built-in status bar text label for the "right-click brings up the Split/ Lock/ Close View" menu, and the Dolphin bar currently replaces this, removing the ability to summon this menu.

I suppose there are two main choices here: 

A) we can either attempt to re-instate this right-click menu behaviour, but I cannot really think of a clean and foolproof way of doing this without making some ugly changes to Konqueror and/ or some ugly Konqueror-specific changes to Dolphin; or

B) we can follow KHTMLParts' lead and, in "KPart"-mode (i.e. when embedded in Konqueror), not use our own text label to show the message, and instead use the KPart system's own status bar text message stuff (the KPart system also provides a progress widget which we can use in place of m_progressBar).  

The disadvantage is that, in KPart mode, we'll lose those cute little Info, Error etc icons next to the status message, and we'll have to either modify DolphinStatusBar so that it can operate in two different modes (one using a label & progress bar for the messages/ progress; the other emitting the relevant signals for use by the KParts system).  This might involve creating an AbstractStatusBar class with DolphinStatusBar and, say, DolphinPartStatusBar as implementations.  

As always, comments, plans, re-namings and nitpicks appreciated :)

I've not documented this heavily but will do so if the general approach is approved.  

Best Wishes,
Simon
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20080826/5b237dad/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dolphin-statusbar-factor.patch
Type: text/x-diff
Size: 22551 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20080826/5b237dad/attachment.patch>