[PATCH] Tiny patch for spring-loaded folders in Dolphin

[Peter Penz]

Am Friday, 8. August 2008 20:20:08 schrieb Simon St James:
> Hi Peter,
>
> On Friday 08 August 2008 18:54:04 you wrote:
> > I don't have and real specifications, the important things from my point
> > of view are:
> >
> > - It should work in the icons-view, details-view (with expandable folders
> > and without expandable folders) and the column-view.
>
> I'm not fully sure what's required here: by "it should work", do you mean
> that the "Folders" panel should have auto-expand when a file is dragged
> onto it from a file in icons-view, details-view and column-view? Or do you
> mean that e.g. a folder in an icons-view should "expand" when a file is
> hovered over it? If the latter, how would you like this to work? I'm having
> difficulty visualising what a folder icon in a grid-like view
> auto-expanding would look like :)

I just meant the simple version: If an item is dragged above a folder X from 
the icon-view, the folder X should get opened after ~300 ms. No "expanding" is 
meant like in a treeview :-) It's the same functionality like offered in 
Konqueror for KDE 3.

> > - Spring loaded folders should be turned off per default -> a setting
> > should be available to turn this feature on (I'd suggest to add one in
> > DolphinSettings::instance().generalSettings()). One exception: in the
> > details- view with expandable folders (= tree view) the spring-loading
> > feature should be turned on always (similar to the treeview in the
> > Panel). Your patch fixes this already perfectly - from my point of view
> > you can commit your patch on trunk.
>
> By "off by default", do you mainly mean "off by default in the Folders
> panel" ... ?

Oh, I just faced the regression that the autoexpanding in the Folders Panel 
(F8) does not work anymore :-( I assumed that this is still working, so what I 
meant is: For treeviews like in the Folders Panel or the details view with 
expandable folders the spring-loaded-folders functionality should _always_ be 
available, as it is easy possible for the user to collapse the folder again or 
to go to the parent.

For other views (icons view, details view without expandable folders) it 
should be turned off per default as it is not possible anymore to go back as 
soon as the folder has been entered during dragging. I'm not sure about the 
column-view here - well let's try it before deciding anything here.

> I don't actually have svn access (I've set myself the goal of 5 accepted
> patches before applying) so if you could apply it, that would be cool :)

OK, I'll commit it next week :-)

> When I have a few KDE3 features re-implemented, I'm planning to blog about
> it, so this would be a good start :)
>
> > Thanks in advance for your support!
>
> Glad to help :)
>
> > PS: I don't have e-mail access until Monday
>
> No problem - hopefully I won't run into anything too hard :)
>
> Best,
> Si.