[PATCH] Konqueror Home URL

[David Faure]

On Thursday 03 January 2008, Robert Knight wrote:
> Hi,
> 
> > I was able to implement it just like described in the idea and committed it
> > already.
> 
> I really don't think that was a good idea.  This is a non-trivial
> change which shouldn't go in hours before release tagging.
> 
> > The URL requester referres to the current profile, if a
> > KonqMainWindow is found higher in the widget hierarchy and it's profile can
> > be found
> 
> That is a hack to put it mildly.  I'm sure David Faure could have
> suggested a better implementation.

Actually, I would like to suggest a different solution altogether.

I understand the need for "a different HomeURL for web 
browsing and for file managing".

But do we really need a HomeURL per profile? Who here is using more than
two home urls? Speak up now or complain when it's too late :)

Initially a profile was just "a set of views (e.g. when using splitters) and
optionally the urls loaded in them (and the window size)", nothing else. Then people started to
add all sorts of things to profiles to solve the webbrowser-vs-filemanager problem:
xmlgui file, toolbar visibility, and now even the home url. I think this makes things
more complex than they should be. It also introduces bugs like: show a toolbar
in the webbrowser, it will appear in the filemanager too, even though toolbar visibility
is saved into the profile. This is because it's -also- saved into konquerorrc.
I think we should choose a more straightforward solution. There are two ways to launch
Konqueror in a default installation: home button and browser button. Let's make those
two ways choose a different "mode" in konqueror (filemanager or webbrowser), and let
this be independent from profiles. In filemanager mode, some settings would come
from a different kconfig file (I'll call it kfmrc for old time's sake). These settings would
include toolbar visibility and the Home URL -- and this way we only have two home urls,
and the configuration module can offer both without having to bother the user with the
notion of profiles.

Advanced users can still use profiles for loading/saving specific view arrangements,
but basic things like home url, toolbar settings etc., which would in any other application
be application-wide settings, should simply exist in two instances in konqueror, (almost
as if konqueror was two applications, but with the difference that .

The attached patch implements the notion of "file manager mode", and uses it
for saving/restoring toolbar visibility settings. Still TODO: add window size to that,
and Home URL, and modify the kcontrol module accordingly. But I thought I'd
first check to see if there are big objections.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: konq_modes.diff
Type: text/x-diff
Size: 7589 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20080417/fb12b239/attachment.diff>