[PATCH] New feature: closed tabs trash bin as in Opera

[Eduardo Robles Elvira]

Hello people!

I've been told we have until tuesday to check in new things in konqueror. So 
today I've been working in my patch. This way you can get the latest version 
of the patch:

svn checkout https://forja.rediris.es/svn/csl-konqueror

I've been posting all the versions of the patch there, so you can get an 
evolution of it watching the log ;-)

Apply it in kdebase/apps source directory with patch -p0 < undo.patch

It comes with multiple window support working, with shortcuts in the popup 
menu and with support for cleaning the closed tabs history.

> I'm also still sad to see KonqUndoManager getting tab-specific code,
> instead of something more generic (application-defined undo command), is
> there any chance you could look at that?

I've looked for a solution but..
There too many many problems that needs to be solved in order to do this, and 
because of that I'm not sure if this is really possible/desirable. I guess 
that we should postpone to deal with this point to a later release.

> If you call erase, the iterator is then invalid, so ++it is wrong - or it
> might skip items, well in any case this is removeClosedTab(ClosedTabItem*
> closedTabItem) so you should just add a "return" inside the if, the
> tabitem can be there only once.

I've looked at this and I think it's fixed. When I call erase I break the loop 
and the iterator isn't used anymore.

I'm going to try to add support for not only closed tabs but also closed 
windows (as in latest opera ;-) but for now I think this patch can be the one 
hehe.

Thanks for reading,
         Eduardo Robles Elvira.
-- 
"The reasonable man adapts himself to the world; the unreasonable one
persists in trying to adapt the world to himself. Therefore all progress
depends on the unreasonable man." (George Bernard Shaw)