Problems with KHTMView (and KHTMLPart) constructors

[Germain Garand]

Hi!

Le Mardi 11 Décembre 2007 14:07, Eeli Kaikkonen a écrit :
> Hi, I'm new here. I had some bugs which I wanted to talk about and I
> told about them in #khtml but nobody answered there. This is more than
> just one bug report, therefore I thought it would be proper to use this
> forum rather than bugs.kde.org.
>
> The heart of the issue is how the KHTMLPart and KHTMLView constructors
> work. It is not possible to set either Part for View later or vice
> versa. This is not usually a problem but if I need to subclass both of
> them it is.

I agree this is an embarrassing problem (along with the repeated breakage, 
thank you for your patience!)

We are not going to change the API at this point, but please check if the 
attached patch may address your concerns.

It adds:
1) the possibility of constructing a KHTMLView beforehand with a 0L part
   pointer. That pointer will be updated by the KHTMLPart constructor.
2) some documentation describing 1) and also view creation from 
   part constructor initialization list
3) a unit test asserting 1)
4) a fix for the early KHTMLGlobal usage problem

Comments and review by other list members welcome.

Greetings,
Germain
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch
Type: text/x-diff
Size: 8099 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20071217/4183d050/attachment.diff>