Bookmark Toolbar show/hide setting

[David Faure]

On Tue Nov 21 2006, Daniel Teske wrote:
> Hi
> 
> The bookmark toolbar show/hide setting is broken. As can be seen in the following bug reports:
> 
> http://bugs.kde.org/show_bug.cgi?id=99616
> http://bugs.kde.org/show_bug.cgi?id=90521
> http://bugs.kde.org/show_bug.cgi?id=132746
> http://bugs.kde.org/show_bug.cgi?id=126556
> 
> The problem is the show/hide setting is saved in konquerorrc and in the profiles. Due to the order these setting are applied, profile first, konquerorrc second, the setting in konquerorrc takes effect.

I definitely had reservations against saving toolbar settings into profiles, because I knew such things would happen... :)

Any idea why we don't apply the konquerorrc settings before the profile settings? Wouldn't that make more sense?

> The obvious correct way to fix that would be to ignore the show/hide setting for the toolbars from konquerorrc. Which unfortunately is in kdelibs.
> So this patch takes the easy (and slightly hacky way) out. On loading profile the show/hide settings of the profile are written to konquerorrc. So that applying the settings in konquerorrc just reapplys the profile settings.
Needs a comment at least. Wouldn't a deleteGroup do the job too? Deleting the config from konquerorrc before the kdeui code that loads from it is called;
this might just apply the default settings though, so that wouldn't be enough.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).