[PATCH] Do not resolve symlinks when clicking on them

David Faure faure at kde.org
Thu Mar 9 11:08:21 GMT 2006


On Tuesday 07 March 2006 20:46, Andras Mantia wrote:
> Hi,
> 
>  I expect this to be a controversial patch, but it is needed to achieve 
> consistency within Konqueror itself. The problem is described in 
> http://bugs.kde.org/123230 . The reason why I changed here and not in 
> the sidebar is because it would be still inconsistent, as the user 
> could enter the directory by typing the path in the location bar.
>  I have no idea why the symlink resolving was needed, maybe it was 
> useful when running applications, but KFileItem::run anyway uses the 
> destination, not the link.

Well if you follow the comment and read KFileItem::run you can see that:
  // When clicking on a link to e.g. $HOME from the desktop, we want to open $HOME

Imagine you have a link to your home on the desktop called "MyHome", when clicking
on it you don't want to see "/home/user/Desktop/MyHome/" in konqueror, but /home/user.

So how do we solve this? In one case a symlink is used to hide the actual location
of a directory (/mnt) and in the other case the actual location (home) *is* where 
we want to go, the symlink is just a convenient way to go there. Do we need a 
desktop-specific hack (making symlink-resolution happen only if the link is on 
the desktop), or does someone have a better idea?

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kfm-devel mailing list