[PATCH] Bugfixes for profiles and preloading.

[Lubos Lunak]

On Wednesday 21 December 2005 16:22, Emanuele Tamponi wrote:
> Hello,
> I just completed a little patch.
> Because my explanation was very lenghtly and needed a lot of html (because
> I pasted some code), I link here the webpage where I wrote the explanation.
>
> The patch is the attached file, but you can download it also from the
> webpage:
>
> http://principe.homelinux.net/patch/
>
> I hope the patch is fine...

 I can't reach the page, but since I don't have much clue about profiles 
anyway I'm going to comment only on the part of the patch directly related to 
preloading, which seems to be only the konq_misc.cc snippet: It doesn't seem 
to be right.

 Preloading, if my memory serves me well, works like this: When a Konqueror 
instance is about to quit, or when its last window is about to be closed, 
it's first checked if there should be an instance kept preloaded for being 
used again later. If yes, this is prevented and the instance is kept for 
reusing later. This means there's a prepared instance running, which saves 
startup costs, and there's often a window prepared as well, which saves the 
cost of setting it up. There's a kded module which takes care of such 
preloaded instances and tells exiting instances whether they should really 
quit or stay around.

 Now, with the patch, if the profile of the kept window in the preloaded 
instance will be different from the one needed, that window will stay around. 
Given how fragile this hack is the window should be at least deleted to 
prevent trouble. However, just creating a new window isn't exactly cheap 
either, that's why the window is reused as well after all, so it might make 
sense to check what the impact is and probably try harder. Depending on what 
the costs are today maybe the kded module should also remember the profile 
for each preloaded instance and when reusing matching one should be 
preferred, or when reusing the window the right profile should be applied to 
it instead of destroying the window and creating a new one.

-- 
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o.  e-mail: l.lunak at suse.cz , l.lunak at kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/