[PATCH] auto-completing URLs on Ctrl-Enter
Thiago Macieira
thiago at kde.org
Wed Feb 1 09:36:34 GMT 2006
Tony Sideris wrote:
>Hello,
>Attached is a patch that will add a feature similar to Firefox, and IE.
> When Ctrl-Enter is pressed in the URL bar the current text will be
> wrapped in "http://" and ".com"...
>
>This was the original idea anyway, but I extended it a little so that
> you can hold down Ctrl and continue pressing Enter to scroll through
> different suffixes (currently com, org, net, edu, gov, de). Once the
> correct url is selected, release ctrl and press Enter.
>
>NOTE: This was coded and tested with the latest FC4 source RPMs. The
> relavant code in SVN is the same so it should apply properly (i hope).
That's an interesting feature. However, I'd like to ask you to modify your
code to do as follows:
1) respect the file's coding styles (indentation is 4 spaces)
2) make the list of suffixes configurable (don't remove the hardcoded
default ones, though). There's no need for GUI, but reading the data from
a .desktop. That way, translators could set their locale's default
suffixes. For instance, I don't have much use for ".de", but I do about
".com.br".
--
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
PGP/GPG: 0x6EF45358; fingerprint:
E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358
1. On frumscafte, hwonne time_t wæs náht, se scieppend þone circolwyrde
wundorcræftlíge cennede and seo eorðe wæs idel and hit wæs gód.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20060201/8440bef1/attachment.sig>
More information about the kfm-devel
mailing list