Results of the khtml scanning
Christoph Bartoschek
bartoschek at gmx.de
Sun Apr 2 13:07:46 BST 2006
Hi,
I made the checks for Ismail and translated the reports into the mail you
got. Here are some remarks:
1. I apologize that I suggested using ||=. I did not check its existence.
However nearly all items you commented are essentially the same: Boolean
variables are used in an arithmetic context. First I tried to comment
them but then decided to only list them.
It is not an error to do that and the standard supports the usage. However
it could be an indication of an error and therefore I did not remove the
items.
2. The source code came from Ismail. You have to ask him to get the correct
revision.
3. In my opinion the programmer should not worry about the performance of &
| ^ compared to && || !=. This is a compiler issue. For example two weeks
ago I read in a comment that on intel xor is slower than !=.
More important is that the reader can understand the code easily. If I see
|=, I think someone is setting a specific bit. This is somehow implied by
the name of the operations.
Greetings
Christoph
More information about the kfm-devel
mailing list