[PATCH] Acid2 comment fix

[David Faure]

On Tuesday 17 May 2005 11:38, Ivor Hewitt wrote:
> On Tuesday 17 May 2005 10:27, Stephan Kulow wrote:
> > Am Dienstag 17 Mai 2005 01:37 schrieb Ivor Hewitt:
> > > Hi,
> > >
> > > This is a patch for Dave Hyatt's acid comment fix (acid6.txt), the logic
> > > looks correct. i.e. the parseComment now ignores anything between paired
> > > "--"'s within a comment block.
> > > Is there any reason not to have this? or is there a more elegant way of
> > > doing this? or is this simply considered an "unnecessary SGML legacy"?
> >
> > You better provide at least some test cases that show it's necessary and
> > how other browsers behave. Fixing this for one web page can easily break it
> > for tons of others ;(
> >
> Hi,
> Indeed. I was just using this description as a reference:
> http://www.htmlhelp.com/reference/wilbur/misc/comment.html

Please try at least khtmltests/html/parser/comments.html (and writecomment.html)
as well as khtmltests/regression/tests/ecma/comments/comment_ext.html

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).