[PATCH] Acid2 comment fix

Allan Sandfeld Jensen kde at carewolf.com
Tue May 17 09:21:13 BST 2005


On Tuesday 17 May 2005 01:37, Ivor Hewitt wrote:
> Hi,
>
> This is a patch for Dave Hyatt's acid comment fix (acid6.txt), the logic
> looks correct. i.e. the parseComment now ignores anything between paired
> "--"'s within a comment block.
> Is there any reason not to have this? or is there a more elegant way of
> doing this? or is this simply considered an "unnecessary SGML legacy"?
>
If we only do it in strict mode the damage is minimal, but I am still hoping 
for the test to be updated. 
If not I will commit it eventually. Thanks for the patch :)

> Also... I saw Allan's commit:
> http://lists.kde.org/?l=kde-cvs&m=111582051619324&w=2
>
> For the render eyes fix - the eyes still don't render for me, should they
> render ok within the acid test page or do they only render as a separate
> test (if you see what I mean!).
>
They only render if you disable plugins. It seems the fallback mechanism was 
never extended to plugin framework. I still need to fix this part.

There are currently a few bugs left for us in Acid2:
1. SGML comments
2. Plugin fallback as mentioned
3. Margin collapsing. Between nose and smile
4. Height of an image which should be invisible (lower left).
5. The smile is calculated too wide and not restricted to the containing box.

`Allan




More information about the kfm-devel mailing list